My first use of Javascript on FrontEnd Mentor

Community feedback

• 

  Joseph•770

  @Jos02378Posted about 3 years ago

  Hey @Geoff-Walker, good job on this solution!

  Some suggestions for you:

  1. Try not to set a fixed height to an element, consider using min-height or not setting the height at all so the element can grow as the content grows.
  2. You can try to watch this video on creating an accordion with less Javascript accordion video.
  3. You can try to follow a CSS naming convention called BEM. You can watch this video for more information Watch the video.
  4. You can try to use relative units like rem and em in the future. Here is a link to an article that explains when to use which unit see the article.

  I hope this helps, good luck!

  1

  ---

  

  Geoff Walker•165

  @Geoff-WalkerPosted about 3 years ago

  @Jos02378

  Thanks Joseph I'll give that a good study rem, em units confuse me at the best of time so that will really help!

  Thankyou

  0