My first React JS project

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi there, Bonrey! 👋

  Well done on this challenge! 👍 And kudos for trying out React! 👏 File structuring was something I was rather confused about, too, when I first tried out React, but I think it becomes easier to understand with practice, of course! 😅

  The text in your solution becomes very, very small when the screen width decreases in the desktop layout. I suggest setting your font-sizes in em or rem so that the size of the text remains more consistent across screen sizes and is more accessible and predictable than setting font-sizes in viewport units.

  Also, if an invalid email is entered into the input and submitted, the value of the input element changes to "[email protected]." I think it would be better if the value of the input remains the same as what the user typed so that they don't get confused and have to delete the replaced text. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  @ApplePieGiraffe thank you! I'll take into account your suggestions! Especially about the font-size.

  As for the "[email protected]", I just followed the design patterns for this challenge. But I agree that it doesn't look good. Sometimes it's indeed better to come up with some features yourself than copy the default pattern 😄

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @Bonrey

  No problem! Glad to help! 👍

  If you look closely at the design JGPs for this challenge, you'll notice that the value of the input element is actually "janeappleseed#gmail.com"—meaning it's only an example of what an invalid email might be and of what the invalid state of the input element should look like. You don't actually have to change the value of the input element to something else for this challenge! 😅

  1

  

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  @ApplePieGiraffe hahah, got this 😅

  1
• 

  Cường•885

  @docuong0912Posted over 3 years ago

  Hi, I just want to know how did you learn React, i'm struggling with it :))

  I was looking for demo react project and luckily,i found yours. Keep doing more React project, i'm waiting more from you <3

  1

  ---

  

  Bonrey•1,130

  @BonreyPosted over 3 years ago

  @docuong0912 well, I just followed some tutorials, looked at other people's React projects, and tried to apply this knowledge in this project. You can check the README.md file for this challenge, where I've written more about used technologies and also provided some links 😉

  And thank you for your kind words! 🙂

  1