My first QR code challenge using HTML and CSS

Community feedback

• 

  P

  Andreas Remdt•950

  @andreasremdtPosted over 2 years ago

  Hey, congrats on solving the challenge :)

  I checked your favicon, it's is used and displayed correctly, so no worries there.

  In my opinion, your code is clean and understandable. One suggestion I have is to use the main element for the container instead of a div. This gives you accessibility benefits because every page is supposed to have one main landmark, here it's the card itself.

  The media query is technically correct, but I don't think that you need one here. Instead, what you can do is setting max-width: 100% on the image itself, which will make it responsive. You can even remove the width: 290px. This way, the image grows and shrinks with the browser without the need to write any media queries. This is also a great way of making videos and other media responsive in CSS. Hope it helps :)

  Marked as helpful

  1

  ---

  

  Cathiscoding•20

  @cathleysPosted over 2 years ago

  @andreasremdt Hello! sorry for the late reply! this is super helpful! Now I know why the image is not getting smaller or bigger when I adjust the browser size. max-width: 100% is the answer! thank you!

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Greetings Cathleys,

  Indeed , well done on your first challenge. Some of my points have been raised already but here is what i think:

  • the image is not responsive in a way, @andreasremdt has addressed it above, it is a good idea to reset images to max-width: 100% - that will make sure that the image can fit fully without overlapping when the container is smaller or the fixed width that had been applied with css. You have currently set the width to 290px, check the site using dev tools or on a mobile that has a screen size of less than 375px , you will notice that the image is overlapping the container. But with a max-width of 100%, the image will be contained in it's container.
  • for font sizes , i would suggest to use rems instead of px , you can read more on this px vs rem

  Happy coding

  Marked as helpful

  0

  ---

  

  Cathiscoding•20

  @cathleysPosted over 2 years ago

  @ChamuMutezva hello! sorry for the late reply. Thank you for your great feedback, this is meaningful to me!

  0
• 

  Madiha Khan•420

  @madkn1311Posted over 2 years ago

  Hello Cathleys,

  Good job on your first challenge..!!

  What I noticed in the CSS for the container is that you have used both width and max-width. Since max-width overrides width so its better to use just max-width.

  All the best for the next challenge. :)

  0