My first QR code card

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7Posted over 1 year ago

  Hi,

  Congratulations on completing this challenge!!🎉🎉🎉 I have a few suggestions that might be of help to you.

  • Replace the div card with a main element. This will remove the accessibility issues. Click here to learn more about html landmarks.

  • For the card, instead of defining the min-width, define the max-width for better responsiveness.

  • You can remove the overflow from the card, as it is not doing anything as such.

  • Center the card to the middle of the screen. You can use either flex or grid to do so.

  Center using flex

  body{
  min-height: 100vh;
  display: flex;
  justify-content: center;
  align-items: center;
  }
  

  Center using grid

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Hope this comment helps you. Have a nice day!!!!

  0