Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My first QR code card

@alexcammeraat

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Agnik7

Posted

Hi,

Congratulations on completing this challenge!!🎉🎉🎉 I have a few suggestions that might be of help to you.

  • Replace the div card with a main element. This will remove the accessibility issues. Click here to learn more about html landmarks.

  • For the card, instead of defining the min-width, define the max-width for better responsiveness.

  • You can remove the overflow from the card, as it is not doing anything as such.

  • Center the card to the middle of the screen. You can use either flex or grid to do so.

Center using flex

body{
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
}

Center using grid

body{
min-height: 100vh;
display: grid;
place-items: center;
}

Hope this comment helps you. Have a nice day!!!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord