Cagri Kizilkan• 210
@cgrkzlkn
Posted
Great job! I have several improvement ideas:
- You can use HTML5 Landmarks for accessibility. HTML5 Landmarks
- You can change
<div class="qrcode">to<main class="qrcode"> - You can wrap
<div class="attribution">with a footer tag. Like this:
<footer>
<div class="attribution">
</div>
</footer>
- You can add box shadow to 'qrcode' element. This tool can be useful : CSSmatic Box Shadow Generator . For example:
.qrcode{
box-shadow: 0px 10px 20px 0px rgba(0, 0, 0, 0.1);
}
Marked as helpful
0
Alex• 10
@romaleks
Posted
@cgrkzlkn Thank you for useful recommendations! I've litterally forgot about box-shadow
1
