Skip to content
Submitted over 2 years ago

My first project, QR code component

Julia•50
@youlia121
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello, This is my first real project, feedback will be appreciated.

Community feedback

  • Elaine•11,400
    @elaineleungPosted over 2 years ago

    Hi Julia, congratulations on completing your first project! I just had a look and it looks pretty good, so well done on getting it to close to the design. You do have a number of accessibility issues and HTML issues in your report, so be sure to check those out and try to fix that. Some of them concern the lack of semantic tags (or landmarks), like the <main> tag, which you can add like this:

    <body>
  <main>
    content here!
  </main>
</body>

    Also, I notice you're using fixed widths; you can try using responsive width properties instead, like max-width; that way, your component can be resized by the browser on smaller screens.

    Great job, and keep coding!

    Marked as helpful
    0
    Julia•50
    @youlia121Posted over 2 years ago

    @elaineleung Thank you for your helpful answer, I will definitely take it into account next time!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord