My first project! Fylo Landingpage

Community feedback

• 

  Simeon Udoh•535

  @simeon4realPosted almost 5 years ago

  Hello @Dani. I just previewed your website site. In addition to the recommendations by Rafael, I will suggest you reduce the font size on smaller screens. I'm currently on Mobile and the text are way too bigger.

  One way I usually fix font-sizing is that I declare a base font size of

  html {
  	font-size: 62.5%;
  }
  

  62.5% means that 1REM = 10PX and not browser default of 16px.

  Then on small screens, using media queries, I set the font-size to

  html {
  	font-size: 50%;
  }
  

  Now 1REM == 8px. This way, all the elements get resized automatically with just that one line of code since I use relative units. You don't have to go back to everywhere you declared font-size: to change them.

  Kindly upvote my feedback if you found it useful.

  2

  ---

  

  Dani•90

  @dagonmar183Posted almost 5 years ago

  Hi @simeon4real! Thanks you so much for your reply. Is very interesting your comment, I will apply it in future projects.

  0
• 

  Rafael Maia Chieregatto•320

  @rafaelmaiachPosted almost 5 years ago

  Hey Dani, congrats on your solution. Very well implemented.

  As some feedback:

  • You could try to use different tags on your html, not only divs for containers. Maybe some sections, for example, would have a better semantinc.

  • As I have a ultrawide monitor, your solutions get a lot of elements with large spaces or their width are very big. I don't have a thought about the best solution for this case, because I'm still studying about, but maybe you could have a max-width for the elements, with the margin: 0 auto for the page. You can try different approachs and resolution and see what fits better

  • Check the accessibility problem on the report and fix it, it's a good way to practice accessibility

  • Maybe you didnt style the border for the Get Started button, you could check the challenge image again and improve the border layout, would looks better.

  2
• 

  yaakoubox•115

  @yaakouboxPosted almost 5 years ago

  Good job But it will be more professionnel if you pay more attention for the position of contents in the page

  1
• 

  Dani•90

  @dagonmar183Posted almost 5 years ago

  Hi Rafael! Thank you very much for your feedback. I like so much your advices and I will try to implement them.

  0