Submitted over 2 years ago
My First Profile Card Component using FlexBox
@MariusSB-code
Design comparison
SolutionDesign
Solution retrospective
All feedback is appreciated!
Community feedback
- @EngineerHamzieyPosted over 2 years ago
Hello, you have done a great job Here are some tips to fix the accessibility issue
- your attribution should be inside a landmark tag. Footer is most suitable here, You can use
<footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">MariusB</a>. </footer>
Or simply wrap the div with a footer tag
<html lang="en">
always add language (lang) attribute to your HTML tag, en in this case means English
In addition Also main is the most suitable here not section, a section is expected to have a heading h1 or ...h6 So you can have
<main class="main"></main>
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord