my first junior challenge

Community feedback

• 

  Benjo Quilario•1,810

  @benjoquilarioPosted almost 3 years ago

  Hey @developython14 Nice job on finishing this one

  Some suggestion:

  • All page content should be contained by landmarks. It will better if the structure of your html file is like this.

  <header></header>
  <main></main>
  <footer></footer>
  

  • You forgot to add the base or reset elements

  html { 
     font-size: 100%;
     box-sizing: border-box;
  }
  * {
     box-sizing: border-box;
  }
  

  • You can check my solution here, if you want to upgrade your page Solution

  Good luck

  Marked as helpful

  0
• 

  Byron•2,290

  @byronbyronPosted almost 3 years ago

  Nice 👌

  Just two things I think are worth checking/fixing...

  • Check your accessibly issues
  • Check what it looks like on a real life phone

  If you do those two things after every project, you’ll smash it! 👍

  Marked as helpful

  0