Design comparison
Solution retrospective
Hi! This is my first JS project on the platform. Have you built this too? Tell me, I will check your solution. I tried to keep an eye on accessibility issues. What can I improve? Thanks to all who will leave a comment. See you to the next project!
Community feedback
- @nikavolkPosted over 2 years ago
Hello Elisa!
I've not done this challenge yet, however I figured I could still test it out!
Visually: I think the design is spot-on, looks great! Two (minor) things that I would perhaps implement myself when doing this challenge:
- disabling the Reset button when the input fields are empty
- when entering or selecting a value into the calculator, that same chosen or entered value is displayed. I think it would be better not to display anything when a correct entry is input.
Technically: It might just be on my device, but the reset button doesn't work for me at all (doesn't clear the fields).
Otherwise amazing job for your first project!
Marked as helpful0@elisa-charrierPosted over 2 years ago@nikavolk Hi! Thank you for the advices.
Disabling the reset button is a great idea, didn't think about it. I'll try to figure out how to do it.
I've corrected the second thing... I used it to check if it worked instead of the console log and forgot to remove.
You're right: the reset button wasn't working. I fixed it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord