Design comparison
Community feedback
- @kamilp522Posted about 2 years ago
Hi! Great work on your first solution!
I have a few sugestions:
Your card isn't centered properly in the background. You can fix it with adding
display: flex
andjustify: content
to yourbody
element. Read more about flexbox here: LinkAlso you probably started your project from the desktop view which is a common mistake and leads to a lot of problems when trying to scale it down to mobile. Do some research about mobile first approach.
Layout isn't responsive, you shouldn't use fixed heights and widthts but use
max-width
and 'max-height` properties for example.Read about media queries to make your layouts change as the size of the device viewport changes. Mozilla has a great info about that: Link
Hope this will help a little. Good luck with your next challenges and happy coding :D
1@QgQ220903Posted about 2 years ago@kamilp522 Thank you for your advice, I really appreciate it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord