Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

my first html css solution

Quy 70

@QgQ220903

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Kamil 120

@kamilp522

Posted

Hi! Great work on your first solution!

I have a few sugestions:

Your card isn't centered properly in the background. You can fix it with adding display: flex and justify: content to your body element. Read more about flexbox here: Link

Also you probably started your project from the desktop view which is a common mistake and leads to a lot of problems when trying to scale it down to mobile. Do some research about mobile first approach.

Layout isn't responsive, you shouldn't use fixed heights and widthts but use max-width and 'max-height` properties for example.

Read about media queries to make your layouts change as the size of the device viewport changes. Mozilla has a great info about that: Link

Hope this will help a little. Good luck with your next challenges and happy coding :D

1

Quy 70

@QgQ220903

Posted

@kamilp522 Thank you for your advice, I really appreciate it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord