My first Grid Experience !

Community feedback

• 

  Anna Leigh•5,135

  @brasspetalsPosted over 3 years ago

  Hi, David! Congrats on completing another solution! 🎉

  Overall, you did a good job, and it responds very nicely. My only suggestion on that front is to add a max-width to your cards container for mobile styling, as the cards tend to get pretty stretched between about 500px-700px. Having them match closer in width to the heading text would look nicer.

  To clear up your accessibility errors:

  • For “Document should have one main landmark”, use a main element to wrap the content of your page, and apply your position styling (padding, margin, display, etc.) to that rather than directly on the body. This will hopefully also clear up the other “landmark” errors in the report - not entirely sure as I’m not familiar with the new report system yet. 🤞
  • For “Page should contain a level-one heading”, I suggest wrapping both of your headings in the .heading-section in a single h1 tag (rather than an h3 and h2) with a span around “powered by technology” in order to apply the bolder styles. You can control the line break through setting a width or max-width with ch units.

  Hope my suggestions help! Happy coding! 😄

  Marked as helpful

  1

  ---

  

  Ahmed Kamel•1,190

  @hmadamkPosted over 3 years ago

  @brasspetals yeah the cards is stretching to much

  0
• 

  Rachael•610

  @RMK-creativePosted over 3 years ago

  Hi David! No feedback other than it looks awesome, nice work 😃

  Marked as helpful

  1
• 

  Corey Gamble•25

  @EthiEnginePosted over 3 years ago

  That looks Good David!

  Marked as helpful

  0