My First Ever Product Card Challenge

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  HI @Ebi-Akangbou,

  Congrats on completing your first challenge. You did good. Add the following on your body tag to center the card on the page. You can always use the below snippet on a parent element with height set to min-height: 100vh.

  display: flex;
  justify-content: center;
  align-items: center;
  

  if you are referring to the color that shows up you hover on the image you can use the before and after CSS pseudo elements on for the overlay color and on for the eye icon.

  1

  ---

  

  Ebi Akangbou•170

  @Ebi-AkangbouPosted about 2 years ago

  Hello @hyrongennike Thanks for your suggestion. I tried using flex at first. But it was not working.

  0
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Ebi Akangbou,

  Congratulation on completing another frontend mentor. Excellent work! I have some suggestions regarding your solution:

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2: If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • The alternate text should not be hyphenated , it should be human readable. For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be avater_png. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • The link wrapping the equilibrium image (image-equilibrium) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • You can use unordered list <ul> to wrap middle part of the component. In each <li> should be <img> and <p>.

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  • You can have a look at my solution here, it might help.

  Hopefully this feedback helps.

  1

  ---

  

  Ebi Akangbou•170

  @Ebi-AkangbouPosted about 2 years ago

  Hello! Thanks for your help. I've seen your solution. It was far better than mine. But I have learnt something.

  0