Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My first challenge in frontend mentor with html and css

GRAVIT 80

@gravit09

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am new to web development I think I have made some mistakes and my code is not DRY please check my code and suggest some best practices and let me know my mistakes.

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello Garvit, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code. For example, you can build this solution with GRID.I saw that you’ve used flexbox to place the content and create the layout.

I think the best way to build this component with two columns is by using GRID LAYOUT since it is simpler to manage the columns and then create the media query for mobile. Here’s the steps to create it with grid create the main block to hold all the content (you can use <main> to wrap), set its width as max-width: 900px (it's the container size) and display: grid / grid-template-column: 1fr 1fr(this means that your component will have two columns with 50% of the container width each thats 450px). To manage the column with the text use flexbox and gap to give it the spacing between the texts or use padding-bottom to separate them.

Then to create the mobile version, all you need to do is to change the container flow vertically with grid-template-column: 1fr.

2.When you download the project files there’s a file called style-guide.md where you can find information such as font-family, hsl color codes, device sizes and the font-size for the headings.

✌️ I hope this helps you and happy coding!

Marked as helpful

1

GRAVIT 80

@gravit09

Posted

@correlucas Thanks for reviewing my code and giving me such a wonderful explanation it meant a lot to me and I will definitely use the grid system for two columns in future projects Thank you, sir

1
Lucas 👾 104,420

@correlucas

Posted

@gravit09 You're welcome Garvit. Keep it up =)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord