My first challenge. Feed back is wanted and needed.

Community feedback

• 

  T

  Grace•31,010

  @grace-snowPosted almost 3 years ago

  Hi

  Your component is touching all sides of my mobile screen. There should always be a gap there.

  You need an interactive element around the image. Anything with a hover style in a design means it’s interactive, and that includes the image on this one.

  The other big learning point here is that you’re misusing the section element at the moment. Section is not meant to be used anywhere you feel tempted to use a div. A div is ok to use in lots of situations. Think of a section like a chapter of a book, it’s for a bigger chunk of content to group it all together, often titled by a h2 (and aria-labelledby that h2)

  One more small thing - don’t use spans alone for text content when you could use a meaningful element like a paragraph.

  All seem small things, all easy to fix, but all important.

  Marked as helpful

  1

  ---

  

  Dennis Race•50

  @D-RacePosted almost 3 years ago

  @grace-snow Thank you for the feedback, much appreciated. I believe I have made the suggested changes.

  0

  

  T

  Grace•31,010

  @grace-snowPosted almost 3 years ago

  @Dennis-Race it doesn’t look like the image has an anchor tag yet. Anything with a hover must be an interactive element

  Marked as helpful

  0