My First Challenge

Community feedback

• 

  Sathya D•310

  @satzzzzz07Posted about 2 years ago

  Hey there, Great work on your solution! Design looks good. There are few suggestions:

  1. The qr component is not centered in the screen. Centering the Element - For Centering the element in the page you can wrap the element in a div and use flexbox more about flexbox.

  Aside these, excellent work again and happy coding :) 👍

  2
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Greg, congratulations for your new solution!

  👏 Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with flexbox using the body as a reference for the container.

  The first thing you need to do is to remove the margins used to align it, then apply min-height: 100vh to the body to make the child (the card/container) align to its size that now will be displaying 100% of the viewport height and then give its alignment with display: flex and align-items: center / justify-items: center.

  1.REMOVE THE MARGIN TO MAKE THE PROPER ALIGNMENT:

  @media (min-width: 375px)
  .container {
      /* margin: 8rem auto; */
      width: 350px;
  }
  

  2.USE MIN-HEIGHT AND FLEXBOX TO ALIGN:

  body {
      min-height: 100vh;
      font-family: "Outfit", sans-serif;
      background-color: var(--lightgray);
      /* padding: 8rem; */
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  ✌️ I hope this helps you and happy coding!

  0