Skip to content
Submitted about 1 year ago

My First Challange: QRCode

deimantejagu•10
@deimantejagu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

HI. I started learning Css and HTML recently. For now it is very difficult for me to make responsive designs. Maybe you have some advice about that? Best tutorials, what is wrong with my first QR code or what points are crucial to know when learning responsive design? Also maybe you have any advice about best practice and writing clean code? Thank you for the answer!

Community feedback

  • Inci Huseynli•310
    @incihuseynliPosted about 1 year ago

    Firstly, congratulations for your first project! You did great work for first step.

    Everything was looking good so far with project, but I would like to give some opinions. You wrote your CSS in main HTML file, but I hope you'll sperate them in different file in your future projects. Even if it's short it's good that they don't inside same file for the sake of file structure. And I think you must forget to change your README.md file.

    That's all I would like to say. This is my first comment in community , I wish it'll give some help. Good luck :)

    Marked as helpful
    1
    deimantejagu•10
    @deimantejaguPosted about 1 year ago

    @incihuseynli thank you! I fixed everything

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord