Submitted 4 months ago

My first challange in frontend mentor

Achmad Anwar Asyirri•100

@asyirri

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

At least it work perfect

What challenges did you encounter, and how did you overcome them?

The challange is to make responsive design to different display on different device's

What specific areas of your project would you like help with?

If I can, i want to improve on my color picking, and sense or feel of spacing at an each block of element to be accurate enough or related to the project

Community feedback

Dylan de Bruijn•3,230
@DylandeBruijnPosted 4 months ago
@asyirri

Hiya! 👋

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things you could improve ✍️

I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

Try using semantic HTML elements like main, section and article.

Try using using relative CSS units like rem and em they make your layout more adaptable.

Try making your solution more responsive!

I hope you find my feedback helpful! 🌟

Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

Happy coding! 😎
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord