My Faq Accordion Card Solution with React

Community feedback

• 

  Millz•530

  @BrezusPosted over 2 years ago

  very good the accordion works great and the layout is good here are a few suggestions :

  1. Your .container class has a height of 100vh i would change that property to min-height: 100vh In your .container-md i noticed you are setting max and min heights generally it is considered bad practice setting heights because it can cause problems we were not expecting so instead let the content eg paragraphs, images or any htmls content to dictate the height of said container.
  2. On .container-md you also set min/max width those can be confusing and they are set to the same value in your code.. what i like to do is set a regular width eg. 'width:80% or width: 80vw' and under it put a max-width of 1000px so it never gets wider than 1000px.
  3. I would remove all the images in your .faq div and set them to be background images check out how to set background-images, how to position background images and how to chain more than one background image. Here are links that could help you out https://developer.mozilla.org/en-US/docs/Web/CSS/background-image, https://www.w3schools.com/css/css3_backgrounds.asp hope this helps

  1