Design comparison
Community feedback
- @azhar1038Posted about 2 years ago
Hi Hunter McGrew, congratulations on completimg this challenge!
I noticed one small issue in mobile view, when you click on the share button, height of card changes. This is due to different height of share menu and author details.
An accessibility tip is to use
button
for share icon instead ofdiv
. Since this button contains image instead of text, make sure to give anaria-label
and setaria-hidden
to the child image. Also you have used section unnecessarily. There is no need to put an image inside section and your header and paragraph can go in same section.Try to use
hn
tags for heading instead of paragraphs.Hope it helps :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord