@correlucas
Posted
👾Hi Mohan, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture>
instead of <img>
wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture>
tag and use the html to code to set when the images should change setting the device max-width
depending of the device (phone / computer) Here’s a guide about how to use picture
: https://www.w3schools.com/tags/tag_picture.asp
You’ve used px
as the unit for sizes but the problem with pixels is that its not optimized for multiple devices and screens. So a good fit its to use rem
or em
that have a better performance and make your site more accessible between different screen sizes and devices. REM
and EM
does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!