Music Card

Community feedback

• 

  Jason Heys•175

  @heyitsganyPosted about 3 years ago

  Nicely done! Your solution looks good, although looking at the live version on GitHub pages there are a few things that could be changed to improve it.

  Firstly, changing the 'container' div to a main element would solve the accessibility issue that your solution is getting.

  Secondly, your background image is mispositioned and doesn't repeat. So, look at making it repeat on the x-axis and let it position itself.

  Otherwise nice work!

  0

  ---

  

  Jontim•145

  @Jon-timPosted about 3 years ago

  @heyitsgany Thank you for your feedback. I think there is a problem "update solution" button, it doesn't update at all, despite the fact that i have updated he code.

  0

  

  Jason Heys•175

  @heyitsganyPosted about 3 years ago

  @Jon-tim I can see you've got two branches on your github for this project. You'll need to push your changes to the main branch for anything to update on the live version. Also, looking at your recent commit; you wanted to change <div class="container"> to <main class="container>. Sorry if I wasn't clear.

  Marked as helpful

  1

  

  Jontim•145

  @Jon-timPosted about 3 years ago

  @heyitsgany

  tried again!

  1