Design comparison
Community feedback
- @ndragun92Posted over 1 year ago
Hello,
Great job! Well-made challenge!
I want to point few things here. I have seen your MainPage.vue and since this is a multi-step form and uses v-if/else conditions that means that some of the components do not need to be present there on the initial page load.
Instead of importing them like
import SecondForm from "./SecondForm.vue";
you can lazy load them to boost performanceconst SecondForm = defineAsyncComponent(() => import('./SecondForm.vue') )
Also, v-for should not use the index as a key (this is least recommended). Use the title if it is unique if not you can mix the title and index like
:key="`${title}--${index}`"
v-for="(title, index) in titles" :key="index"
Overall good job! Keep it up!
Marked as helpful0@riansyhPosted over 1 year ago@ndragun92 all right thank you for the insight, i will try to implement your suggestions!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord