Multi-step form built with SolidJS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution had generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component for body

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  
      margin: 0;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  C H A R A N 🎯•2,670

  @0xabdulPosted over 1 year ago

  Hello Developer well congrats on successfully completed the Multi-step form

  • A Little bit suggestions for improve your code

  • In Html 📃 :

  • HEADING ⚠️

  • the Html documents should contain one level of headings don't skip the headings

  • Ex :

  <h1> </h1>
  <h2> </h2>
  <h3> </h3>
  <h4> </h4>
  

  • Note : heading must be include in html page and use the headings line by line or sequence way
  • In Css 🎨 :
  • And your Multi-step form is not center aligning so fix them

  body {
  display:grid;
  place-items:center;
  margin:0;
  height:100vh;
  }
  

  • I Hope you find the solution and it's useful Comment for you your Multi-step form is so nice Finnally Happy Coding Developer

  Marked as helpful

  0