Design comparison
Community feedback
- @lack21Posted over 1 year ago
Good work 👍, but I have some recommendations!
-
Replace
height: 100vh
tomin-height: 100vh
in the#root
, the difference is that, when you setheight: 100vh
to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to setmin-height: 100vh
, like this in case content is overflowing container will adjust to it. -
Remove
width: 100vw
from the#root
,#root
which is located indiv
is a block level element which by default takes full space available, sowidth: 100vw
does nothing here!
0@prolixtrexPosted over 1 year ago@lack21 thanks. I really appreciate. I will take into consideration
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord