multicolumn card feature section, using sass

Community feedback

• 

  bikeinman•1,080

  @BikeInManPosted over 2 years ago

  The design on desktop seems to be very close to the design. Congratulations.

  Some suggestions about markup.

  1. top-info should be wrapped in a header and not article

  2. h2, h1 is the not the right order. Here you seemed to have used it only for sizing. h1, h2 are not meant for sizing but for section headings in long form articles. You could have wrapped both the lines in h1 and one of them in span inside it and style span separately.

  3. About card titles, span is not the right element. May be h2 or h3 is better. span is mostly used in between long sentences and you briefly want to accent few words inside it.

  Other suggestions.

  1. Some padding is required on the sides on tablet sizes. Now it overflows.

  You can make this challenge more interesting by adding some interactivity to the cards like a hover effect and also making each card a link. They are supposed to lead somewhere, right?

  If you can push yourself a little more, you may even try to display 2x2 cards on tablet sizes.

  Good Luck.

  Marked as helpful

  0

  ---

  

  Julian Florez•190

  @juliflorezgPosted over 2 years ago

  @BikeInMan Hey! Thanks for your comments on my solution, I'll try and fix the issues with the HTML tags. And as for the cards layout I actually wrote the 2x2 grid but I guess it didn't work or I made some mistake there haha, will look on that. Again thanks for your suggestions!

  0