Design comparison
Solution retrospective
The only thing I didn't build is the hover/ active state. Although there was instructions about it, there was no clarity of the hover/active 's colour or style.
Feedbacks are welcome! Help like as well star my GitHub repo.
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
Here are some suggestions to further improve your solution:
- Use
<ul>
and<li>
for the content under "Why Us": Since the content is a list of items, it's more semantically correct to use an unordered list (<ul>
) and list items (<li>
) instead of just using paragraph (<p>
).
- Consider using
min-h-screen
(which translates tomin-height: 100vh
) rather than combining breakpoints with heights likelg:h-[100vh] h-auto
. This approach is more straightforward and ensures that there are no unexpected issues on smaller screens. It simplifies your code while achieving the same result.
I hope you find it useful! ๐
Happy coding!
Marked as helpful1@chungvuiloongPosted about 1 year agoHi @MelvinAguilar,
Thank you for your feedback and your support ๐.
Amazing feedback!
I tried both solutions and it worked great!
Hope to see more of your feedback as it is very helpful.
Have you considered being a mentor?
Happy Hacking!
0 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord