Mostly used css flex and just one media query for mobile+tablet view
Design comparison
Solution retrospective
This is my first submission via github.
- I am concerned about is the mess i have created in the stylesheet.css file, any suggestions on how should i improve??
- Did i do it okay??
- To the experts, what will you recommend me to code with less mess??
And sorry for the looong url vercel is a long one :p Thank You :)
Community feedback
- @david-r-frederickPosted almost 4 years ago
You should create separate files for either a) areas of the code by category (for instance: layout, typography, variables, etc.) or b) different components (for instance: the rating cards, the quote cards, etc.). After you have your separate files, you just import them separately into your html file. It sounds counterintuitive and like it's more work, but in the end it isn't because you save yourself time but not having to search for what you're looking for. Other than that, it looks responsive and pretty well done. It's bigger than the initial design, but that's not a bad thing to me. One thing I would change is your media query for the rating boxes. Looking at 5 stars on two different columns is weird. You could either micromanage it by making your content smaller as the width of the window shrinks or (to me, more ideally) you could set an earlier break point for when you change to mobile view.
1@david-r-frederickPosted almost 4 years ago@appsplash99 I see I had a typo here. It should have said "5 stars on two different rows is weird." Anyhow, you're welcome!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord