Mortgage-Repayment-Calculator

Community feedback

• 

  Ilya Andreev•750

  @NeoScripterPosted 2 months ago

  I recently did the same challendge and would like to give you feedback on your solution.

  1. Your calculator is too large. The tablet size is not implemented so it shifts from the mobile to the desktop right away. You might wanna check the dimensions in the design file.

  2. The result shows doesn't have dot and commas separation, which makes it ready hard to read large numbers. You might wanna implement Intl.NumberFormat (built-in JS method). Here is how I used it:

  const NUMBER_FORMATTER = new Intl.NumberFormat(undefined); this.totalField.value = this.currency + NUMBER_FORMATTER.format(totalInterest);

  3. The red validation error color doesn't disappear from the fields after I enter the correct values and get the calculation result.

  4. Nothing stops me from entering letters and a very large number to the mortgage amount field, which result in NaN on the display. You might wanna implement dinamic validation of the number before the calculation.

  5. It's hard to select the radio button, the area for it is super tiny. What you can do is to create a pseudo element to the radio button, put it in a position absolute and make it occupy all the size of its parent container (it will work if you set the parent container to position relative). As the result, the pseudo element will propagate all the clicks to the radio button, making it super easy to click (you can check out my solution if you need to see how it is implemented).

  6. After I click the Clear All button, the invalid input fields still stay red.

  I hope these suggestions help!

  0