Design comparison
Community feedback
- @brunomoletaPosted 4 months ago
Hello Sara,
I spent some time going through your code, for I'm learning Vue.js and it's not every day you see a more robust project done in this framework around here as you did.
First, I would advise you to make incremental commits as you sent only a "first commit" and this way, it's not possible to understand how you progressed with your project.
Also, I believe it would be more organized if you set all your states at a
useStore.ts
file. This post by Alex Bruno is relevant for providing a state manager with Composition API.I cloned your repo and went to do some refactoring.
When we have to separate the form from the part on the right where it renders the result of the mortgage, it gets messy. If you'd like, take a look.
Furthermore, it might be a better option instead of:
const mortgageAmount = ref<number>() const mortgageTerm = ref<number>() const interestRate = ref<number>() const mortgageType = defineModel<string>('mortgageType')
To go with
reactive
object. Again, for better readability.The app looks nice and works well, though.
Congrats on the effort. Best regards from 🇧🇷
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord