Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

More React hooks, better file organization, better SCSS use learned

Bao Dang 110

@weebao

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


My second React app here. There were some features not in the original design that I wanted to put in so it took me longer than I expected, but the final product got me real satisfied, plus I learned a lot too. Any feedback is appreciated.

Community feedback

@TylerDurden230

Posted

Hi, I really like your solution! It look like exactly the same as the example. You got just few html errors, easy to fix as you can see.

Just a little thing. I really appreciate the control on negative numbers, but your solution doesn't handle, visually, big numbers. Maybe you could put a max number of digit to avoid the problem. (My solution neither, but I just thought about it).

Still a very very good job!

Marked as helpful

1

Bao Dang 110

@weebao

Posted

@TylerDurden230 Hey I appreciate your feedback. I struggled thinking about what to do with the big numbers so I was thinking of either putting a limit or using overflow: hidden, but I just left it as it is since I would want to calculate big numbers too. Thank you!

0

@TylerDurden230

Posted

@weebao I 've been too fussy :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord