@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your
body
element (this method uses CSSGrid
):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
More Info:📚
[Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]
- Increase 📈 the
width
of you component to better match the FEM design.
- The
alt tag
description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- A
media query
is not needed for this challenge. Using responsive properties will do in making your content responsive.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful
@Effyz1228
Posted
@vcarames Thank you so much for the helpful feedback, really appreciate it! So without using media query, you suggest me use rem and em instead to achieve the same result?