Modified 1st challenge

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To properly center your content to your page, you will want to add the following to your body element (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info:📚

  [Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]

  • Increase 📈 the width of you component to better match the FEM design.

  • The alt tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • A media query is not needed for this challenge. Using responsive properties will do in making your content responsive.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1

  ---

  

  Effy Zhang•60

  @Effyz1228Posted almost 2 years ago

  @vcarames Thank you so much for the helpful feedback, really appreciate it! So without using media query, you suggest me use rem and em instead to achieve the same result?

  0
• 

  Adriano•38,120

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Effy Zhang, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

  body {
      margin: 0;
      padding: 0;
      display: flex;
      align-items: center;
      flex-direction: column;
      justify-content: center;
      min-height: 100vh;
  }
  

  This part of the media query is not needed as the project is responsive without it!

  .card {
      /* max-width: 325px; */
      /* border-radius: 15px; */
      /* padding: 15px;  */
    }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Effy Zhang•60

  @Effyz1228Posted almost 2 years ago

  @AdrianoEscarabote Hi Thanks for the feedback. I was wondering how to make the project responsive without the media query?

  0