Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
To center .qr-container on the page using flexbox, replace the height in the body with
min-height: 100vh
.For a responsive content,
- Replace the width in .qr-container with max-width, increase the value and give it the same padding value for all the sides
max-width: 320px which is 20rem/em padding:16px which is 1rem/em
- Give the img a max-width of 100% and a border-radius value, the rest are not needed.
Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1@helenclxPosted over 1 year ago@Hassiai Thank you for your feedback. I have adjusted my code based on your suggestions.
0 - Replace the width in .qr-container with max-width, increase the value and give it the same padding value for all the sides
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord