Hi
I'm afraid you need to rewrite the html on this. All changes should be easy to do though
- You need to Indent your code consistently. Your code editor can even do this automatically for you on save. This makes the code easier to read, is an established standard and prevents bugs from silly things like skipped closing tags which start to happen a lot on bigger pages
- its extremely important to use appropriate meaningful html elements for the content. Only headings should be heading tags, and these must go in order, starting from h1 and never skipping levels
- the stats should be 3 bullet points in a list, not headings and paragraphs. It makes no sense to have headings with numbers in like 300k. Those numbers can be wrapped in spans or strong tags to make them display block and acheive the styling
- read up about landmarks. Your accessibility errors on this are because the component should be inside a main element and attribution should be inside a footer element
Other general styling feedback is the shadow looks too dark compared to the design, and the card is touching my screen edges on mobile. There should always be a little space around it like the design
Marked as helpful
@snake321
Posted
@grace-snow thanks for your feedback I will rewrite the code and will solve these issues and then I will send you the link then pls give me your feedback thank you so much for telling me my mistakes.....
@snake321
Posted
@grace-snow pls give me feedback now because I think I have solved all issues which you told me
@snake321 I'm afraid this still isn't right
- alt text is incorrect
alt="victor_dp". Alt should be human readable text, it's not code for a computer. In this case it should be the person's name - you still have h2s with no content under them. That makes no sense at all. As I said previously, the stats need to be 3 bullets in a list. Turn off styling for the page and the structure should be understandable and formatted as if it was any other document
- remove all those brs. None of them should be there. They are meaningful and will be readout as "break" to screenreaders which you rarely want to happen. Again as I said before you can wrap the stats numbers in span/strong and set to display block of you want them on their own line
Marked as helpful
@snake321
Posted
@grace-snow Thank you for your feedback but I didn't understand this (Brs) would pls tell what do you mean of this
@snake321 every time you have added <br/> that should not be there. It is extremely rare you need to use these, almost never.
Marked as helpful
@snake321
Posted
@grace-snow Thank you so much for your such amazing feedback I think I have solve all issues which you told me so would you plz check my solution give me valuable feedback if I deserve ..... @grace-snow your feedback are always helpful so never stop to help needy people keep coding keep learning and keep helping
