Mobile-First with Vue.js and SASS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted about 4 years ago

  Hi Ilan,

  I'm not sure the layout is doing what it's meant to - I'll post a screenshot of what I see on slack for you. The issues all come from using pixel values and padding to create your layout. I'd strongly recommend you use alternative units like viewport units or percentages, or maybe alternate layout methods like grid to lay out your page.

  The other issue I see with this is everything is a div. That makes it completely inaccessible I'm afraid. Similarly, your alt text isn't giving meaning like it should. So I'd go back and address the HTML structure afresh - make sure all accessibility concerns are covered, like keyboard interactivity and semantic structure with styles turned off.

  That all said, there's some really nice animations and API work here. Just don't skip the basics ;)

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Ilan! 👋

  It's been a while and so it's nice to see you complete another challenge! You've done a really good job on this one! 👏

  I like the little loading animation that shows when a new quote is generated and the transition between opening and closing the information box is nice and smooth! 🤩

  The only things I might suggest are allowing the background of the site to fill the entire screen so that there's no empty space to the bottom of the page when the height of the viewport increases and perhaps changing to a tablet-friendly layout a little after 90em since I think the desktop layout will still look nice on smaller desktop screens. 😉

  Keep coding (and happy coding, too)! 😁

  0