Mobile-first solution with SASS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi, Leandro! 👋

  Good work on this challenge! 👍 Your solution looks great and responds pretty well! 😀

  I only suggest taking a look at your solution report and trying to clear up the errors that are there. If you ever decide to use <article> or <section> tags, make sure that you include a heading inside those elements to identify them. In this case, I think you can simply turn one of the elements inside each of the testimonial cards (such as the titles) into headings to clear up your solution report and improve the semantics and accessibility of your solution. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Leandro•120

  @LeandroRicoPosted over 3 years ago

  @ApplePieGiraffe Hi! 👋

  I reviewed the report and you are absolutely right. I will change those items as you pointed out.

  Thanks for the feedback 🙂

  0
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Leandro,

  Congrats for completing this challenge ! 🙂

  I'm not an expert in SASS but your structure seems good, at least I can quickly understand what your code is doing with a glance so it's good sign haha.

  Just on your @import , it's recommended to use @use because the first one is now deprecated.

  You can find more information on the SASS official documentation (https://sass-lang.com/documentation/at-rules/import) where it's well explained. Also here is a great video of Kevin Powell that shows how to use it (https://www.youtube.com/watch?v=CR-a8upNjJ0).

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  

  Leandro•120

  @LeandroRicoPosted over 3 years ago

  @RayaneBengaoui I had no idea that @import was deprecated. I will fix it and keep it in mind for future projects.

  Thanks for pointing that out 🙂.

  0