Design comparison
Solution retrospective
Wow, this was more of a challenge that I thought it would be! It is my first time creating a responsive navigation with hamburger menu - this was probably the most difficult part for me. I definitely need to improve but I found some helpful articles, including a fun one from @tediko to animate the burger!
Specific questions that I have:
-
Currently the modal stays open when scrolling - is there a way to close it?
-
I attempted to use sass on this one, even though its a small project. Any feedback on how to do it better?
-
Any other feedback, would be great to hear too 😊
Community feedback
- @lancemartijaPosted over 3 years ago
Wow, it's almost identical! Great job! I'm also working on this project as well and though it looks simple enough, it's still giving me quite a few headaches. Anyway, I just want to suggest something about how you use Sass. It seems like the Sass Team is phasing out the use of "@import" and are urging users to use "@use" and/or "@forward" instead. I don't know if you know this already, but it wouldn't hurt mentioning it now, yes? Hahaha. Anyway, congratulations on finishing this project. Keep on coding!
Marked as helpful2@RMK-creativePosted over 3 years ago@lancemartija Thanks Lance, I wasn't aware about Sass phasing out @import! This project gave me a lot of headaches, and took far longer than I had anticipated 😂. Good luck on yours!
1 - @afrusselPosted over 3 years ago
Nice work. Almost it's like the mockup.
- you can use onscroll event to close the modal.
- SASS is a good css pre process but for small project you can also use https://stylus-lang.com/
Marked as helpful1@RMK-creativePosted over 3 years ago@afrussel Thank you, I'll check out your suggestions. Much appreciated!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord