Skip to content
Submitted over 4 years ago

Mobile-first solution using WEBPACK, SASS, and JS

Wissem•125
@Wiss69
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social media dashboard with theme switcher
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hi everyone,

For my first challenge, I make this social media dashboard with theme switcher using Webpack, SASS and JS. Please let me feedback on the structure in my code. I'm always looking for improvment in my code as I'm still learning front-end dev !

Thank you

Community feedback

  • Daniel Pineda•100
    @dpineda64Posted over 4 years ago

    Hi, Wissem good job, only some comments... seems like your js code doesn't need the jquery, I would suggest extracting your code from the "app" var and removing the dependency, so your bundle does not become heavier with unnecessary deps. And with the webpack config its a good idea to have a "common" config file where your entry points, rules and plugins necessary to build your app reside, and separate file(s) where you extend your common config for dev or prod, that way you can maintain a SSOT and avoid problems when deploying to prod because you forgot to added X alias/entry to the config

    0
    Wissem•125
    @Wiss69Posted over 4 years ago

    @dpineda64 Thank you for your feedback I really appreciate your remarks so I will improve my code skills.

    Best regards

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord