Mobile-first solution using Flexbox QR CODE component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the <footer"> element has been placed bottom using margin. So let me explain, How you can place the component at bottom with using fixed positioning for footer

  ---

  ---

  • Luckily you already used Flex layout of css to center the component, So you just want to add fixed position for <footer> element to place it in bottom of the page

  .attribution {
     position: fixed;
     bottom: 1em;
  }
  

  ---

  • Now remove these styles, after removing you can able to see the changes

  ---

  .attribution {
    margin-top: 15px;
  }
  

  ---

  • Now your component has been properly at bottom

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Oluwafemi Kolade•230

  @Kolade1024Posted over 1 year ago

  This is awesome..Thanks for this@0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Kolade1024 Glad you found it helpful ! 🤠

  1
• 

  gianella•40

  @gianellinPosted over 1 year ago

  I like your solution for this challenge. Clean HTML too! It is good practice for SEO to have one H1 tag per page (which you do have!). And since there is one, you do not really need to create a class or id in this instance . For style purposes, you can do : h1{...}.

  Great job!

  1

  ---

  

  Oluwafemi Kolade•230

  @Kolade1024Posted over 1 year ago

  Thanks a lot for your feedback @gianellin. Since it's just one h1 tag, no need for class or I'd. Noted

  0