Design comparison
Solution retrospective
I think it's ok, but any feedback will be appreciated :)
Community feedback
- @grace-snowPosted over 3 years ago
Hi Liandro
This looks really nice and the html is well structured.
I recommend removing the picture elements from your html - they are only useful if you need to serve multiple image resolutions not a single tiny svg.
Also, try to remove all the heavy nesting in your css. Keeping specificity as low as possible is best practice and and nesting element selectors like this
main section picture img
will cause real problems if you get into that habit now and come to bigger projects later.Hope these pointers help you. I look forward to seeing your next solution
2@LeandroRicoPosted over 3 years agoHi Grace!
Wow, i didn't know that about the picture elements.
And you are right about specificity, i totally forgot that, but i'll keep in mind for the next projects.
Thanks for your feedback! π
0 - @aman152003Posted over 3 years ago
Great Work, I also submitted the same solution but your looks better π
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord