Mobile-first solution using Flexbox and BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Alphonzo Escolar! 👋

  Just wanted to say, good work on this challenge! 👍 Everything looks pretty great and the card component responds nicely! 🙌

  You can style the focused state of the link using the :focus selector, but there's actually already an outline that appears when the link is focused, so I think it's fine (unless you want to style the outline differently or something). 😉

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @ApplePieGiraffe

  Yep you have right. I thought that the outline was styled but it wasn't. Thanks Apple! :D

  question => what's about your project, how often you are you adding a focus to a link?

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @SzymonRojek

  Haha, cool! 👍

  I used to not be very aware of the importance of adding focused states to elements, but nowadays I think I try to add a focus state to anything interactive (including links) so that it's easy to tell when a user tabs on to an element using their keyboard. 😉

  0
• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi phonzdev,

  Well done :D

  I have checked mainly your HTML, a few tips below:**

  • instead of div class="container" you can take the main tag;
  • in my opinion we don't have to use ul>li in the second box: h2 and two paragraphs will be ok;
  • add focus to a link;
  • check a project in your browser by using the inspector on different devices (especially mobiles) => there is a problem with the link;

  Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1
• 

  Alphonzo Escolar•120

  @phonzdevPosted almost 4 years ago

  Thanks @SzymonRojek for your feedback! :) With regards to adding focus to a link, do you mean the pseudo selector?

  0

  ---

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @phonzdev

  @ApplePieGiraffe already mentioned, you do not have to add it because the outline already appears when the link is focused.

  Anyway, I can recommend this article => A Complete Guide to Links and Buttons

  Happy coding :D

  1