@Hassiai
Posted
Replace<div class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
There is no need to give the body a height value, padding and margin: 0 auto.
To center .card on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
USING GRID:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
For a responsive content give .card a fixed max-width value and a padding value for all the sides. max-width: 320px which is 20rem and padding: 1rem which is 16px
.
Give the img a max-width of 100% for a responsive image instead of width and a border-radius value.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful