Mobile-first solution using CSS Flexbox.

Community feedback

• 

  P

  Øystein Håberg•10,510

  @Islandstone89Posted 8 months ago

  Hi Nicolas. Here is some feedback.

  HTML:

  • The icons are decorative, meaning the alt text should be empty: alt="".

  • "Learn More" would navigate to another page, hence it is not a button but a link.

  • If you include the <footer>, its text should be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Remove margin, overflow and the position properties on the card container.

  • To center the card container horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • Remove all widths and heights in px.

  • Give the card container a max-width in rem, so it doesn't get too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Add some padding on "Learn More".

  • Media queries must be in rem.

  Marked as helpful

  1

  ---

  

  P

  Nicolas Guzman Meneses•75

  @NicolasGuzmanMPosted 8 months ago

  @Islandstone89 Thank you! Your feedback is highly appreciated. I'll get on the code again, and I'll try to improve it.

  1