Mobile-first solution using BootStrap

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  you should change your main background-size: contain; from contain to background-size: 100vw 40vh;

  Marked as helpful

  1

  ---

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @palgramming

  I'll try this thanks you.

  0

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @palgramming

  I've made the modification you said, it works good ;)

  Thanks

  0
• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  For small work not need to use bootstrap better use flexbox. Your main container is not center align vertically.

  Marked as helpful

  0

  ---

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @afrussel

  Yeah I know for the vertical alignment. I'll rework this later.

  And I used bootstrap for training, and speed of coding.

  0

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @afrussel

  The card is now centered :)

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Headings should be in sequential order with an h1 element being the first heading. Do not skip headings.

  Marked as helpful

  0

  ---

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @ChamuMutezva

  Thank you for your advice I've totally forgot this. I've made this challenge like a component.

  0

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @ChamuMutezva

  Modification made ;)

  W3C is happy !

  0
• 

  Harmanjot Singh•985

  @arkharman12Posted over 3 years ago

  On what parts did you use Bootstrap. I don't see the use of Bootstrap on something like this. Happy to follow up.

  0

  ---

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @arkharman12

  The card is a bootstrap component and I used it a lot even if I wrote a lot of css.

  0