Skip to content
Submitted about 3 years ago

Mobile-first solution using BEM and SCSS

Vicktor•900
@Victor-Nyagudi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I separated the illustration hero image from the rest of the card because I found this worked better for me. However, I noticed a small gap between the two which wasn't caused by any margin, and I inspected each element to make sure.

Is there an explanation for this? Does the <header> tag I wrapped the image in leave a space below it and the next block-level element?

I found a workaround, but I'm curious what others have to say about this.

Community feedback

  • Fluffy Kas•7,715
    @FluffyKasPosted about 3 years ago

    Hiya, you can get rid of the small gap if you set display: block on your image. If you're curious about why this is happening, watch this awesome video: (https://www.youtube.com/watch?v=plOl7TNc89A&t=2s)

    Marked as helpful
    1
    Vicktor•900
    @Victor-NyagudiPosted about 3 years ago

    @FluffyKas Thank you. That solved the problem.

    0
  • Mathieu•160
    @mathieu-superposePosted about 3 years ago

    I have no proper explanation, since the height of the header should be defined by the image it contains, but using display:flex makes rid of it.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord