Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile-first solution

@Favourite-Codes

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@denissejoyce

Posted

Hi there, good job finishing the challenge! Just a few suggestions to improve your code —

  • instead of assigning a specific width for the body (#hero1), you may instead just use 100% (if needed, you may also just not set a width value), that way there wouldn't be a horizontal scrollbar when the viewport is smaller;
  • i'm not totally sure why there was a specified height for #hero2, but if you remove that, that should help fix the height problem of the container;
  • make sure to add your font style to your css file
  • also just like what was mentioned in the other replies, you have the wrong path for your img
0

@Favourite-Codes

Posted

Thank you @denissejoyce

0

@Favourite-Codes

Posted

After running the codes on vscode, the QR code image appeared but when I uploaded on my github the run it. the QR code is not showing. Why?

0

@codster15

Posted

Don't worry let me check @Favourite-Codes

0

@codster15

Posted

i have seen your code brother you have selected the wrong height of containers correct it and img is not loading because of wrong path @Favourite-Codes

1

@Favourite-Codes

Posted

Thank you@codster15 Explain what you mean by wrong path. Thanks

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord