Mobile-first solution

Community feedback

• 

  P

  Denisse Joyce•290

  @denissejoycePosted about 1 year ago

  Hi there, good job finishing the challenge! Just a few suggestions to improve your code —

  • instead of assigning a specific width for the body (#hero1), you may instead just use 100% (if needed, you may also just not set a width value), that way there wouldn't be a horizontal scrollbar when the viewport is smaller;
  • i'm not totally sure why there was a specified height for #hero2, but if you remove that, that should help fix the height problem of the container;
  • make sure to add your font style to your css file
  • also just like what was mentioned in the other replies, you have the wrong path for your img

  0

  ---

  

  Favourite-Codes•10

  @Favourite-CodesPosted about 1 year ago

  Thank you @denissejoyce

  0
• 

  Favourite-Codes•10

  @Favourite-CodesPosted about 1 year ago

  After running the codes on vscode, the QR code image appeared but when I uploaded on my github the run it. the QR code is not showing. Why?

  0

  ---

  

  Codster dev•170

  @codster15Posted about 1 year ago

  Don't worry let me check @Favourite-Codes

  0

  

  Codster dev•170

  @codster15Posted about 1 year ago

  i have seen your code brother you have selected the wrong height of containers correct it and img is not loading because of wrong path @Favourite-Codes

  1

  

  Favourite-Codes•10

  @Favourite-CodesPosted about 1 year ago

  Thank you@codster15 Explain what you mean by wrong path. Thanks

  0