@RocTanweer
Posted
Hello @Ron 😀
Another cool project here from you..!!
It looks perfect and responsive and there is hardly anything that I could say...I don't know if it's my eyes but your counter container like elements with font-weight bold is not transitioning with the theme color changer (maybe you forgot to put transition on those 😅) forgive me if I am wrong.
Edited : There should be a tabindex="-1" or something on the label because there should be only one element to switch theme when keyboard users are navigating the site, no? But if you wish two elements to change theme(your personal opinion) then you are not giving an outline to label which makes the user wonder which element is focused when they first tap tab key.
As for the semantic HTML , I would do, div.wrapper -> main.wrapper and main -> section
About putting putting a div tag inside <a> tag read this
That's all I have to say here!!
Hope it helps and happy coding
@rontoyhacao
Posted
@RocTanweer I actually didn't include transition on the texts, thank you so much for the feedback. :))
@RocTanweer
Posted
@rontoyhacao My pleasure. I am not very sure but you could use article tag at .card-container because each card is independently containing it's own content
