Here is some feedback
- don't capitalise landmark or element names in html
- IDs are not for styling! Use classes as style selectors. If you want to understand what the ID attribute is for I've written a detailed post about IDs in HTML
- Please Indent your code consistently so it's easier to read and spot bugs. Your code editor can even do this formatting automatically for you with prettier.
- you can remove all divs inside the card component. They are all unnecessary and bloating the html for no benefit.
- Jessica's picture is meaningful content in my opinion so should have alt text.
- you have invalid html in the list. Only list items can be direct children of lists. Move the links inside the list items.
- the attribution should be in a footer outside of the main landmark.
- always use a modern css reset at the start of the styles in every project. Andy Bell has a good one you can look up and use. Get into the habit of doing this straight away in every project you do.
- Font size must never ever be in px
- make sure you understand the difference between padding and margin. And never use large padding or margin to try and build a layout.
- the background and border radius should be on the links not list items.
- this challenge should not have a media query. And even if it did need one, you shouldn't set it at such a large size, and must define it in rem or em not px. Here is a post about using media queries well
- the card must not have a width or height. It should only have a max width in rem.
Marked as helpful