Mobile-first Room Homepage using SASS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Danielle S.! 👋

  Nice work on this challenge! 🙌 I think your solution responds well! 👍

  A few things I suggest are,

  • Using a <button> element to wrap the mobile menu icon (since it is a button) in order to improve the accessibility of your solution.
  • Adding object-fit: cover to the slider image in the desktop layout to make sure that it is clipped (not stretched or squeezed) when its size changes.
  • Perhaps giving a fixed height to the slider section of the page so that its remains the same (and doesn't jump around) when different slides are shown. 😉

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Danielle S.•140

  @dstrickl7Posted over 3 years ago

  @ApplePieGiraffe Thank you so much! This is super helpful feedback. I didn't even realize you could put an image into a button element.

  1