Mobile-first responsive component w/ sign up form. HTML, CSS, JS
Design comparison
Solution retrospective
Hi everyone! This is my second challenge, first one with JS. I had a lot of fun doing it and I look forward to reading your feedback. The only problem I ran into was the error icon file - it appeared to be damaged. At first I tried to replace it with a similar one, but I ended up not including it. I still think it looks good.
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Greetings, anaharri! 👋
Nice effort on this challenge! 👏 It's great to hear that you had a lot of fun completing it! 👍
A few things I'd like to suggest are,
- Taking a look at your solution report and trying to clear up the errors that are there in order to improve the accessibility of your solution. It looks like you need to label the input elements in some way in order to identify them on the page.
- Removing the error messages and styles once the user enters valid input into the form fields and hits the submit button again (currently, the error messages and styles simply remain in their place).
- Adding a max-width to the form to prevent it from becoming too wide on extra-large screens.
- Adding a transition the button make its hover state a little more smooth would be a nice touch. 😉
Hope those tips help. 🙂
Keep coding (and happy coding, too)! 😁
0@anaharriPosted over 3 years agoAwesome! Thank you so much for taking the time to review my solution, I really appreciate it. I'm updating all the things you pointed out :) Cheers and happy coding to you too!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord